Skip to content

Conversation

@sfc-gh-dmatthews
Copy link
Contributor

📚 Context

Add pages to describe the concepts of advanced themeing

🧠 Description of Changes

[WIP]

  • Custom fonts

Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@sfc-gh-dmatthews sfc-gh-dmatthews marked this pull request as draft April 10, 2025 07:23
Copy link
Collaborator

@jrieke jrieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great overall! Left a few comments here and there, none of them blocking/overly important, feel free to decide as you like.

The two more general (and more important) comments I have are:

  1. I find it a bit odd that we're never listing all of the options in this guide, and are not even linking to where they are displayed on the config options page. I assume if I were a developer, I'd do the following thing: Google "Streamlit theming", go to the first page (probably this one), read the intro on how it works, and then look for a list of theming options that I can copy/paste into my config file and play around with. If I currently land on the page, I basically need to read through everything and then compile that list of options myself. (I totally get you don't want to simply replicate what's on the config options page, but then we should at least link to that prominently I think).

  2. It would be great to show some images on the first page to make it clear what you can do! I know you're also working on adding examples and can totally be a follow-up. But would be great to make this very visual. We could at least have one image somewhere that shows a custom theme (similar to the old page), or even a small gallery of different theme examples that you can click on to view the apps.


## Default Streamlit colors

Streamlit comes with two preconfigured themes: light and dark. If you don't specify a theme, for each user, Streamlit will attempt to use the preconfigured theme that best matches their browser settings.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be cool to add an image of the default light/dark theme below this paragraph.

@sfc-gh-dmatthews sfc-gh-dmatthews marked this pull request as ready for review May 19, 2025 21:41
@sfc-gh-dmatthews sfc-gh-dmatthews requested a review from a team as a code owner May 19, 2025 21:41
@sfc-gh-dmatthews sfc-gh-dmatthews requested review from sfc-gh-mfaulkner and removed request for a team May 19, 2025 21:41
Copy link
Contributor

@sfc-gh-mfaulkner sfc-gh-mfaulkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some spelling mistakes and a few comments.
When I ask a question, I don't usually need an answer; I just want to call your attention to a possible issue for users.
As always, let me know if YOU have questions!

@sfc-gh-dmatthews sfc-gh-dmatthews merged commit 077563c into main May 22, 2025
5 checks passed
@sfc-gh-dmatthews sfc-gh-dmatthews deleted the feature/theming branch May 22, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants