-
Notifications
You must be signed in to change notification settings - Fork 616
Add advanced theming #1275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add advanced theming #1275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great overall! Left a few comments here and there, none of them blocking/overly important, feel free to decide as you like.
The two more general (and more important) comments I have are:
-
I find it a bit odd that we're never listing all of the options in this guide, and are not even linking to where they are displayed on the config options page. I assume if I were a developer, I'd do the following thing: Google "Streamlit theming", go to the first page (probably this one), read the intro on how it works, and then look for a list of theming options that I can copy/paste into my config file and play around with. If I currently land on the page, I basically need to read through everything and then compile that list of options myself. (I totally get you don't want to simply replicate what's on the config options page, but then we should at least link to that prominently I think).
-
It would be great to show some images on the first page to make it clear what you can do! I know you're also working on adding examples and can totally be a follow-up. But would be great to make this very visual. We could at least have one image somewhere that shows a custom theme (similar to the old page), or even a small gallery of different theme examples that you can click on to view the apps.
|
|
||
| ## Default Streamlit colors | ||
|
|
||
| Streamlit comes with two preconfigured themes: light and dark. If you don't specify a theme, for each user, Streamlit will attempt to use the preconfigured theme that best matches their browser settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be cool to add an image of the default light/dark theme below this paragraph.
content/develop/concepts/configuration/theming-colors-and-borders.md
Outdated
Show resolved
Hide resolved
content/develop/concepts/configuration/theming-colors-and-borders.md
Outdated
Show resolved
Hide resolved
content/develop/concepts/configuration/theming-colors-and-borders.md
Outdated
Show resolved
Hide resolved
content/develop/concepts/configuration/theming-colors-and-borders.md
Outdated
Show resolved
Hide resolved
sfc-gh-mfaulkner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some spelling mistakes and a few comments.
When I ask a question, I don't usually need an answer; I just want to call your attention to a possible issue for users.
As always, let me know if YOU have questions!
content/develop/concepts/configuration/theming-colors-and-borders.md
Outdated
Show resolved
Hide resolved
content/develop/concepts/configuration/theming-colors-and-borders.md
Outdated
Show resolved
Hide resolved
content/develop/concepts/configuration/theming-colors-and-borders.md
Outdated
Show resolved
Hide resolved
content/develop/concepts/configuration/theming-colors-and-borders.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Melinda Faulkner <[email protected]>
…nto feature/theming
📚 Context
Add pages to describe the concepts of advanced themeing
🧠 Description of Changes
[WIP]
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.